Fixing protobuf generation and InstrumentationScope #665
Conversation
switching over to using opentelemetry-proto's own mechanism for generating protobuf interfaces, and updating interfaces to latest version
this is the latest version that seems to work with out grpc exporter, further investigation required for 0.15.0+
Codecov Report
@@ Coverage Diff @@
## main #665 +/- ##
=========================================
Coverage 85.25% 85.26%
Complexity 1153 1153
=========================================
Files 128 128
Lines 2788 2789 +1
=========================================
+ Hits 2377 2378 +1
Misses 411 411
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
script/proto_gen.sh
Outdated
| rm -R ./$REPO_DIR | ||
| git clone https://github.com/open-telemetry/$REPO_DIR | ||
| cd "${DESTINATION_DIR}" || exit | ||
| rm -rf ./${REPO_DIR} |
There was a problem hiding this comment.
probably want a check for something here. If ${REPO_DIR} ends up being empty or being inadvertently set some other way......
There was a problem hiding this comment.
It's set a couple of lines up, so I think this is safe. I've confirmed that it's portable enough to be run from / or /scripts and still work... And, it works if ${REPO_DIR} is empty (which is usually is)
script/proto_gen.sh
Outdated
| echo "$TAG" | ||
| echo "Generating protobuf files for version ${TAG} ..." | ||
| make gen-php | ||
| rm -rf ${GPBMETA_DIR} ${OTEL_DIR} |
|
|
||
| echo "Cleaning up..." | ||
| rm -rf ./${REPO_DIR} |
There was a problem hiding this comment.
Ditto in re: rm -rf
|
setting this to draft, since I now think I can get it working with 0.16 - the issue looks to be the renaming of InstrumentationLibrary to Scope |
…rotobuf InstrumentationLibrary is now deprecated in favour of InstrumentationScope. Making this change resolves issues with grpc+protobuf exports being ignored by the otel collector, so we now can update the proto interfaces to latest.
brettmc
changed the title
switching over to using opentelemetry-proto's own mechanism for generating protobuf interfaces, and
updating interfaces to latest version which works with our grpc exporter (v0.14.0). A separate issue + PR will
be required to work out why grpc exporting doesn't work with v0.15.0+
fixes: #660